From ef305ee94cf4e0c7c40096099e8a73afa2958b85 Mon Sep 17 00:00:00 2001
From: Dominic Kempf <dokempf@users.noreply.github.com>
Date: Tue, 13 Dec 2022 11:33:34 +0100
Subject: [PATCH] Fix ID generation for relative paths (#35)

So far, there was implicit assumption on the used paths being absolute.

Co-authored-by: Inga Ulusoy <inga.ulusoy@uni-heidelberg.de>
---
 misinformation/test/data/example_utils_init_dict.json | 6 +++---
 misinformation/test/test_utils.py                     | 4 ++--
 misinformation/utils.py                               | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/misinformation/test/data/example_utils_init_dict.json b/misinformation/test/data/example_utils_init_dict.json
index 088ab6b..6f28a86 100644
--- a/misinformation/test/data/example_utils_init_dict.json
+++ b/misinformation/test/data/example_utils_init_dict.json
@@ -1,6 +1,6 @@
 {
     "image_faces": {
-        "filename": "/test/data/image_faces.jpg"}, 
-        "image_objects": 
-        {"filename": "/test/data/image_objects.jpg"}
+        "filename": "./test/data/image_faces.jpg"},
+    "image_objects":
+        {"filename": "./test/data/image_objects.jpg"}
 }
\ No newline at end of file
diff --git a/misinformation/test/test_utils.py b/misinformation/test/test_utils.py
index ec0f9ff..9479ed5 100644
--- a/misinformation/test/test_utils.py
+++ b/misinformation/test/test_utils.py
@@ -12,8 +12,8 @@ def test_find_files():
 
 def test_initialize_dict():
     result = [
-        "/test/data/image_faces.jpg",
-        "/test/data/image_objects.jpg",
+        "./test/data/image_faces.jpg",
+        "./test/data/image_objects.jpg",
     ]
     mydict = ut.initialize_dict(result)
     with open("./test/data/example_utils_init_dict.json", "r") as file:
diff --git a/misinformation/utils.py b/misinformation/utils.py
index 8675afe..b5fe19d 100644
--- a/misinformation/utils.py
+++ b/misinformation/utils.py
@@ -75,8 +75,8 @@ def find_files(path=None, pattern="*.png", recursive=True, limit=20):
 def initialize_dict(filelist: list) -> dict:
     mydict = {}
     for img_path in filelist:
-        id_ = img_path.split(".")[0].split("/")[-1]
-        mydict[id_] = {"filename": img_path}
+        id = os.path.splitext(os.path.basename(img_path))[0]
+        mydict[id] = {"filename": img_path}
     return mydict